Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#980 - Added locale to all messages from the emulator #987

Merged
merged 4 commits into from
Oct 15, 2018

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Oct 15, 2018

#980 - Added locale to all activities from the emulator

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -51,15 +51,14 @@ export default function startConversation(botEmulator: BotEmulator) {

return JSON.parse(optionsJson).conversationId;
}) || uniqueId();

const currentUser = botEmulator.facilities.users.usersById(botEmulator.facilities.users.currentUserId);
const {users, conversations} = botEmulator.facilities;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace inside braces:

const { users, conversations } = ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Justin Wilaby added 2 commits October 15, 2018 12:26
…Microsoft/BotFramework-Emulator into jwilaby/#980-conversation-update-locale
@justinwilaby justinwilaby merged commit 4168554 into v4 Oct 15, 2018
@justinwilaby justinwilaby deleted the jwilaby/#980-conversation-update-locale branch October 15, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants