Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new Cognitive Services Speech Services #1442

Merged
merged 17 commits into from
Dec 7, 2018
Merged

Support new Cognitive Services Speech Services #1442

merged 17 commits into from
Dec 7, 2018

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 5, 2018 •
edited

Will fix #1320, fix #1336, and fix #1422

Background

This PR will add support of Cognitive Services Speech Services.

Changelog

Added

  • Support Cognitive Services Speech Services, in PR #1442
    • Sample for Speech Services (both subscription key and authorization token flow)
    • Sample for using lexical result (text normalization)

@compulim compulim added 4.2 p0 Must Fix. Release-blocker labels Dec 5, 2018
@compulim compulim added this to the v4.2 milestone Dec 5, 2018
@compulim compulim changed the title DRAFT: Support new Cognitive Services Speech Services [DRAFT] Support new Cognitive Services Speech Services Dec 5, 2018
compulim
compulim commented Dec 6, 2018
View reviewed changes
README.md Show resolved Hide resolved
compulim
compulim commented Dec 6, 2018
View reviewed changes
serve.json Show resolved Hide resolved
@compulim compulim self-assigned this Dec 6, 2018
@compulim compulim changed the title [DRAFT] Support new Cognitive Services Speech Services Support new Cognitive Services Speech Services Dec 6, 2018
stevengum
stevengum reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick but otherwise looks fine!

packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js Outdated Show resolved Hide resolved
tonyanziano
tonyanziano approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

justinwilaby
justinwilaby suggested changes Dec 6, 2018
View reviewed changes
Copy link

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor clarifications and recommendations

@compulim compulim mentioned this pull request Dec 7, 2018
Closed
@compulim compulim merged commit f483950 into microsoft:master Dec 7, 2018
@compulim compulim deleted the feat-speech-services branch December 7, 2018 16:58
@corinagum corinagum mentioned this pull request Dec 7, 2018
Closed
@coveralls
Copy link

coveralls commented Dec 8, 2018 •
edited

Pull Request Test Coverage Report for Build 550

  • 2 of 18 (11.11%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 44.881%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/SendBox/DictationInterims.js 0 1 0.0%
packages/bundle/src/createCognitiveServicesBingSpeechPonyfillFactory.js 0 7 0.0%
packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js 0 8 0.0%
Totals Coverage Status
Change from base Build 547: -0.1%
Covered Lines: 715
Relevant Lines: 1420
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum left review comments

@justinwilaby justinwilaby justinwilaby approved these changes

@tonyanziano tonyanziano tonyanziano approved these changes

@corinagum corinagum Awaiting requested review from corinagum

Assignees

@compulim compulim

Labels
p0 Must Fix. Release-blocker
Projects
None yet
Milestone
v4.2
5 participants
@compulim @coveralls @justinwilaby @tonyanziano @stevengum