Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1512, sanitization of anchors accessibility #1530

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Fix #1512, sanitization of anchors accessibility #1530

merged 3 commits into from
Dec 21, 2018

Conversation

corinagum
Copy link
Contributor

Fix #1512

Adding 'title' to the list of allowed attributes for anchors makes this a simple fix. :) See below for hover on new sanitized anchor:

image

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited

Pull Request Test Coverage Report for Build 646

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.979%
Totals Coverage Status
Change from base Build 638: 0.0%
Covered Lines: 726
Relevant Lines: 1441
💛 - Coveralls

compulim
compulim approved these changes Dec 21, 2018
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 7b745f6 into microsoft:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedding a "Title" in Markdown Link does not render correctly in Web Chat window
3 participants
@corinagum @coveralls @compulim