Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding a "Title" in Markdown Link does not render correctly in Web Chat window #1512

Closed
vbhatt opened this issue Dec 18, 2018 · 2 comments · Fixed by #1530
Closed

Embedding a "Title" in Markdown Link does not render correctly in Web Chat window #1512

vbhatt opened this issue Dec 18, 2018 · 2 comments · Fixed by #1530
Assignees
Labels

Comments

@vbhatt
Copy link

vbhatt commented Dec 18, 2018

The WebChat window should render the "Title" correctly for Accessibility (ADA) compliance. See the example below.
I'm an inline-style link with title does not get rendered correctly in Webchat window as the url get's mangled to create a bad link.

@compulim compulim changed the title Embedding a "Title" in Markdown Link does not render correctly in Webchat window Embedding a "Title" in Markdown Link does not render correctly in Web Chat window Dec 18, 2018
@compulim
Copy link
Contributor

compulim commented Dec 18, 2018

We are using Markdown-It and copying your Markdown to https://markdown-it.github.io/ looks good to me.

If title doesn't shows up, looks like there is a bug in Web Chat and we need to fix that asap.

Update: title doesn't show up in Web Chat, but it show up in Markdown-It demo page.

Note to fixer

  • Type echo [I'm an inline-style link with title](https://stackoverflow.com/help/how-to-ask "How to Home page") in MockBot
  • Hover mouse on, it should show tooltip "How to Home page"
  • Checks if something wrong in renderMarkdown.js

@compulim
Copy link
Contributor

@vbhatt Really thanks for your report.

We really love to make Web Chat accessible to all users, we have an accessibility push going out probably next week. If you think there are potential areas for improvements, please do let us know.

@corinagum corinagum self-assigned this Dec 21, 2018
corinagum pushed a commit to corinagum/BotFramework-WebChat that referenced this issue Dec 21, 2018
corinagum pushed a commit that referenced this issue Dec 21, 2018
* Fix #1512, sanitization of anchors accessibility

* Update CHANGELOG.md

* PR Fix
@corinagum corinagum removed this from P0 in 4.3 Prioritization Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants