-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES Modules - Unable to load a circular module tree #3492
Comments
I cloned the test repo, changed all absolute wwwroot path to relative, created a (The change is pushed to my fork: It was able to load with |
|
Opened internal bug 13132989 and assigned to edgehtml team. |
@suwc thanks for this quick response and resolution. Is there anyway to get an update on the internal bug? Will keep testing here otherwise. |
@guybedford, thanks for reporting and follow-up. |
That's excellent to hear, thanks @suwc! |
I've run this test case of 170 modules with some circular references and no actual code at all against Edge 41.16257.1000.0, and it seems it is enough to stall the browser completely. Safari handles this case in under a second, and Chrome have just fixed a bug for it to load faster as well.
To replicate, clone the repo at https://github.com/guybedford/modules-slow-tree, run a local http server, and navigate to test.html. This should result in a long loop that never resolves (and it happens pretty quickly in the tree in Edge it seems).
Getting the resolution performance will be a priority for real world use cases. Just let me know if there is anything further I can do to help.
The text was updated successfully, but these errors were encountered: