Fix #2770: Implement Intl.getCanonicalLocales #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Ubuntu static_ubuntu_linux_release please |
|
Ping @bterlson @kunalspathak @tcare |
tcare
reviewed
Apr 17, 2017
test/Intl/GetCanonicalLocales.js
Outdated
| assert.areEqual(Intl.getCanonicalLocales({ '0': 'en-us' }), [], "Objects which might look like arrays are fine, but treated as 0 length."); | ||
| assert.areEqual(Intl.getCanonicalLocales({ 'a': 'b' }), [], "Arbitrary Objects are fine, treated as 0-length arrays."); | ||
|
|
||
| // TODO test this |
There was a problem hiding this comment.
Yeah sorry about the TODOs. I wanted to get this out for review. I'll add more tests to cover the gaps in the next iteration.
test/Intl/GetCanonicalLocales.js
Outdated
| assert.areEqual(Intl.getCanonicalLocales('xx-zzz'), ['xx-zzz'], ""); // TODO double-check canonicalization routine, v8 makes this 'zzz' | ||
| assert.areEqual(Intl.getCanonicalLocales('xx-abcd-zz'), ['xx-Abcd-ZZ'], | ||
| "xx-Abcd-ZZ: [unsupported language xx] using [unsupported script Abcd] as used in [unsupported locale ZZ]"); | ||
| // TODO -u- extension keys |
bterlson
approved these changes
Apr 19, 2017
| @@ -1,4 +1,4 @@ | |||
| //------------------------------------------------------------------------------------------------------- | |||
| //------------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
There should be awards for bug fixes this severe.
There was a problem hiding this comment.
lol. Like I said, drive by cleanup. :P
tcare
approved these changes
Apr 19, 2017
dilijev
commented
May 9, 2017
| @@ -51,7 +51,7 @@ var tests = [ | |||
| } | |||
| catch (e) { | |||
| if (!(e instanceof RangeError)) { | |||
| fail("Incorrect exception was thrown."); | |||
| assert.fail("Incorrect exception was thrown."); | |||
dilijev
force-pushed
the
intl-getCanonicalLocales
branch
3 times, most recently
from
e4a6dc6
to
ca56a2b
Compare
|
Note: I'm porting this PR to |
|
Fixing CI in #2962 |
|
Nevermind -- after talking offline with @digitalinfinity this is not needed in release/2.0. Retargeting back to master. |
dilijev
force-pushed
the
intl-getCanonicalLocales
branch
from
ca56a2b
to
a7c298a
Compare
dilijev
force-pushed
the
intl-getCanonicalLocales
branch
3 times, most recently
from
a379e5b
to
578717d
Compare
* NumberFormatOptions.js: Move test which is the same everywhere to the platform-common test. * DateTimeFormatOptions.js: Fix fail -> assert.fail. * Remove explicit -Intl from tests. They are tagged Intl already and if the tests are running then Intl will be on by default in that configuration.
dilijev
force-pushed
the
intl-getCanonicalLocales
branch
from
578717d
to
fe530a8
Compare
chakrabot
pushed a commit
that referenced
this pull request
May 12, 2017
Merge pull request #2818 from dilijev:intl-getCanonicalLocales https://tc39.github.io/ecma402/#sec-intl.getcanonicallocales https://tc39.github.io/ecma402/#sec-canonicalizelocalelist See: tc39/ecma402#78 tc39/ecma402#46 Fixes #2770.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tc39.github.io/ecma402/#sec-intl.getcanonicallocales
https://tc39.github.io/ecma402/#sec-canonicalizelocalelist
See:
tc39/ecma402#78
tc39/ecma402#46
Fixes #2770.