PIX: Pixel count/cost pass #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 14, 2017 14:06
|
@jeffnn, |
python3kgae
approved these changes
Jul 25, 2017
lib/HLSL/DxilModule.cpp
Outdated
| MDTuple *pEntry = m_pMDHelper->EmitDxilEntryPointTuple(pEntryFunc, EntryName, pMDSig, pNewResource, pMDProperties); | ||
| MDTuple *pMDSignatures = m_pMDHelper->EmitDxilSignatures(*m_EntrySignature); | ||
| MDTuple *pMDProperties = EmitDxilShaderProperties(); | ||
| EmitLLVMUsed(); // necessary? |
lib/HLSL/DxilModule.cpp
Outdated
| MDTuple *pMDSignatures = m_pMDHelper->EmitDxilSignatures(*m_EntrySignature); | ||
| MDTuple *pMDProperties = EmitDxilShaderProperties(); | ||
| EmitLLVMUsed(); // necessary? | ||
| // todo: what about type system? |
There was a problem hiding this comment.
If new structure type is added, need to re-emit type system.
There was a problem hiding this comment.
I think I am adding a new type, since I'm declaring a UAV with type struct{int32}...
| auto OffsetIndex = Builder.CreateAdd(ClampedIndex, NumPixelsArg); | ||
|
|
||
| // Step 3: Increment UAV value by the weight | ||
| (void)Builder.CreateCall(AtomicOpFunc,{ |
There was a problem hiding this comment.
What's the (void) here for?
There was a problem hiding this comment.
It's just explicitly telling the reader that I don't care about the return value.
|
✅ Build DirectXShaderCompiler 1.0.544 completed (commit 45691d702d by @) |
|
✅ Build DirectXShaderCompiler 1.0.554 completed (commit fc5b5591f7 by @) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this is not quite right yet, so I'd appreciate feedback.
Xiang, in particular, I am not confident about my changes to DxilModule. The goal is to re-emit the input signature. These are my questions:
-I'm not sure about the type system: Is it feasible, if unlikely, that I might introduce a new type with the new UAVs and CBs I'm adding?
-Do we need to call EmitLLVMUsed? It seems like not, since I'm not touching any global variables?
The actual pass is intended to echo what we already do for DXBC in PIX for the "pixel cost", "depth complexity" and "overdraw" visualizers. You can probably infer what the pass does from the names "overdraw" and "depth complexity": For each pixel rendered it increments a corresponding counter in a UAV of a buffer that is the same size as the render target. The "pixel cost" pass does the same thing, only the increment is a weight value calculated from the total cost of the draw call, as derived from PIX's GPU-side profiling system.