-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks that return status streams should be replaced with calls to IProgress<StreamStatus> #108
Comments
Instead of returning var p = new Progress<Docker.DotNet.PullStatus>(status =>
{
// Do something with the status? Update a UI/PS/Service on the Sync Context of your choice.
});
await PullImageAsync(/*params*/, p);
|
I updated the tile which was very misleading. My response above is what we actually want. Not to change the return type to return progress but rather pass in an |
@jterry75 as mentioned on #143, Lets implement this issue. I would like to align here the proper method signatures:
When I got answer for those two I'll submit the PR. Thanks |
|
Perfect! Will do it tonight when get home. Thanks @jterry75 |
I decided to not use I think Please review when you can so I can move to the others. Thanks! Appreciate the support! :) |
This has been merged. Self assigning to cleanup Push/PullImageAsync in the v1.13 branch given the inclusion of JSONMessage etc. |
Thanks @jterry75 let me what else todo :) |
Resolves dotnet#108. Full implements the IProgress<Stream> changes for the v1.13 api change using JSONMessage JSONProgress and JSONError
Introduce extensible remote path quoting mechanism. Fixes issues dotnet#256 and dotnet#108.
Methods that return a
Task<Stream>
likePullImageAsync
could instead returnTask<IProgress<Stream>>
to abstract away some of the details of how docker reports it's progress. This should simplify patterns for callers who want to report that progress.@jterry75 Can expand on what we are looking for here.
The text was updated successfully, but these errors were encountered: