-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page blob device #147
Page blob device #147
Conversation
…o page-blob-device
Testing of this PR also hindered by #148, although not completely blocked, |
… tests to also run for AzurePageBlobDevice.
I think this device should be in its own project instead of within FASTER.core. Then, users can opt in to the feature, otherwise they would have to take a NuGet dependency on the Azure related NuGet just to run FASTER core. Project and namespace could be named FASTER.devices.AzurePageBlobDevice. |
@badrishc I had to add a lot more code to deal with the race around Create. Will squash all these commits when merging. |
This PR implements an
IDevice
backed by Azure page blob storage.Still TODO:
So far this PR is tested by replacingDevices::CreateLogDevice
with one that returnsAzurePageBlobStorage
instead ofLocalStorageDevice
. All tests pass, but performance is an order of magnitude slower. So probably should not check those in.For unit tests, we will want to use an emulator. Need to figure out how to set that up with Azure pipelines.Unit test performance is visibly worse than local disk when using emulator, and even worse than that when using a real storage account. While it is expected, I need to run some more benchmarks to see if the slowdown is reasonable.Fix #139