Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement final_act using the scope_exit design from P0052R5 #551

Closed
wants to merge 1 commit into from

Conversation

CaseyCarter
Copy link
Member

Fixes #125.

@neilmacintosh
Copy link
Collaborator

Thanks for the PR @CaseyCarter!

At the moment, we like the simplicity of the design of final_act as it stands (modulo bugs). We can revisit whether to harmonize final_act with a standardized facility that offers similar functionality once there is such a thing (P0052 is still in-flight for now).

So I'll leave thi PR open, but mark it "deferred" for now (because I wanted to use that label and have never had a chance before ;-)).

@JordanMaples
Copy link
Contributor

Maintainer's call: closing this as the code has diverged significantly. Additionally, it looks like most of the changes @CaseyCarter wanted to implement were added in other PRs since this. Please file an issue or re-open if there are additional improvements you'd like to add to final_action. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finally() mishandles modifiable lvalues
5 participants