Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

alm: correct pass args within Trace methods. #708

Merged
merged 1 commit into from
Aug 7, 2018
Merged

alm: correct pass args within Trace methods. #708

merged 1 commit into from
Aug 7, 2018

Conversation

whoisj
Copy link
Contributor

@whoisj whoisj commented Aug 7, 2018

When WriteException calls WriteLine it must pass the filePath, lineNumber, and methodName arguments to WriteLine otherwise data loss occurs.

@whoisj
alm: correct pass args within Trace methods.
962fc3f 
When `WriteException` calls `WriteLine` it must pass the `filePath`, `lineNumber`, and `methodName` arguments to `WriteLine` otherwise data loss occurs.
@whoisj whoisj added bug Marks an issue as tracking a bug, or marks a pull request as fixing a bug. cla-signed The required Contribution License Agreement has already been signed, or does not need to be signed. labels Aug 7, 2018
@whoisj whoisj added this to the vNext milestone Aug 7, 2018
@whoisj whoisj merged commit 8b8d52e into microsoft:master Aug 7, 2018
@whoisj whoisj deleted the correct-trace branch August 7, 2018 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Marks an issue as tracking a bug, or marks a pull request as fixing a bug. cla-signed The required Contribution License Agreement has already been signed, or does not need to be signed.
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.
1 participant
@whoisj