Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fixed some typos and grammatical errors #1738

Merged
merged 1 commit into from Oct 10, 2018
Merged

[docs] fixed some typos and grammatical errors #1738

merged 1 commit into from Oct 10, 2018

Conversation

pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 9, 2018

No description provided.

@msftclas
Copy link

msftclas commented Oct 9, 2018 •
edited

CLA assistant check
All CLA requirements met.

@StrikerRUS
Copy link
Collaborator

Hi @pushkyn !

Thanks for you contribution!

Unfortunately, modifying parameters description (Parameters.rst) is not so trivial. You should make your changes into the config.h file and then run python ./helper/parameter_generator.py script. The python script will update the docs. That is how it works.

StrikerRUS
StrikerRUS reviewed Oct 9, 2018
View reviewed changes
docs/Python-Intro.rst Outdated

The ``Dataset`` object in LightGBM is very memory-efficient, due to it only need to save discrete bins.
However, Numpy/Array/Pandas object is memory cost.
If you concern about your memory consumption, you can save memory according to following:
If your concern about your memory consumption, you can save memory according to the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that concern is a verb here, so you is OK. Or you can change concern to worry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I updated it

@pushkyn
Copy link
Contributor Author

pushkyn commented Oct 10, 2018

Hi @pushkyn !

Thanks for you contribution!

Unfortunately, modifying parameters description (Parameters.rst) is not so trivial. You should make your changes into the config.h file and then run python ./helper/parameter_generator.py script. The python script will update the docs. That is how it works.

I'm sorry, I was not attentive enough when I read the docs for contribute. Now I updated config.h file. Thanks.

@guolinke guolinke merged commit ac6951d into microsoft:master Oct 10, 2018
@StrikerRUS
Copy link
Collaborator

@pushkyn No problem! Thanks a lot!

@pushkyn pushkyn deleted the docs-fix-typos branch October 10, 2018 10:02
@StrikerRUS StrikerRUS mentioned this pull request Nov 30, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS left review comments

@guolinke guolinke guolinke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pushkyn @msftclas @StrikerRUS @guolinke