Fixes failing to find msbuild when VS 2015 not installed and using 14393 SDK #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that use ms build version 14.
StephenHodgson
changed the title
|
@reillydonovan, @brean let me know if this fixes it for you guys. |
|
@brean @reillydonovan - Can you two test and see if this resolves the issues, so we can merge the fix? Thanks! |
|
I can confirm that this works when publishing via the MRT build window to APPX and deployed to the hololens via the device manager. Tested using: Fall Creators Update |
|
The fix is for publishing to an older SDK without vs 2015. So the real test is building and deploying while targeting the 14393 SDK or lower |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1146 Wouldn't build for SDKs that use ms build version 14 and VS 2015 was not installed.