Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add scalastyle check into hooks #1528

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

serena-ruan
Copy link
Contributor

@serena-ruan serena-ruan commented Jun 13, 2022

Summary

Add sbt scalastyle check for both main/test projects so that we won't forget fix them until seeing the pipeline fails.

Tests

Local tested

Dependency changes

None.

AB#1828400

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #1528 (77786b5) into master (63ccc8f) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
- Coverage   84.33%   84.19%   -0.14%     
==========================================
  Files         297      290       -7     
  Lines       14912    14777     -135     
  Branches      718      718              
==========================================
- Hits        12576    12442     -134     
+ Misses       2336     2335       -1     
Impacted Files Coverage Δ
...org/apache/spark/ml/param/JsonEncodableParam.scala 57.89% <0.00%> (-26.32%) ⬇️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 67.64% <0.00%> (-14.71%) ⬇️
...g/apache/spark/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) ⬇️
...re/src/main/python/synapse/ml/core/schema/Utils.py 67.10% <0.00%> (-5.27%) ⬇️
...soft/azure/synapse/ml/cognitive/TextToSpeech.scala 84.84% <0.00%> (-3.04%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 86.59% <0.00%> (-2.69%) ⬇️
...crosoft/azure/synapse/ml/lightgbm/TrainUtils.scala 83.64% <0.00%> (-2.52%) ⬇️
.../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala 86.01% <0.00%> (-1.40%) ⬇️
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 73.40% <0.00%> (-1.07%) ⬇️
...t/azure/synapse/ml/cognitive/BingImageSearch.scala 89.28% <0.00%> (-0.90%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafacdd...77786b5. Read the comment docs.

@serena-ruan serena-ruan merged commit 0bd3e07 into microsoft:master Jun 13, 2022
@serena-ruan serena-ruan deleted the serena/addScalaStyle branch June 13, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants