Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky forms test #1584

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Conversation

mhamilton723
Copy link
Collaborator

@mhamilton723 mhamilton723 commented Jul 22, 2022

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1893461

@mhamilton723
Copy link
Collaborator Author

/azp run

@github-actions
Copy link

Hey @mhamilton723 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #1584 (715bcf7) into master (a6a2718) will decrease coverage by 2.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
- Coverage   78.86%   76.58%   -2.28%     
==========================================
  Files         305      298       -7     
  Lines       15776    15641     -135     
  Branches      732      732              
==========================================
- Hits        12441    11979     -462     
- Misses       3335     3662     +327     
Impacted Files Coverage Δ
...soft/azure/synapse/ml/cognitive/AudioStreams.scala 0.00% <0.00%> (-87.88%) ⬇️
...t/azure/synapse/ml/cognitive/SpeechToTextSDK.scala 16.47% <0.00%> (-74.12%) ⬇️
...crosoft/azure/synapse/ml/cognitive/SpeechAPI.scala 0.00% <0.00%> (-70.00%) ⬇️
...crosoft/azure/synapse/ml/io/http/RESTHelpers.scala 64.00% <0.00%> (-32.00%) ⬇️
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 37.23% <0.00%> (-12.77%) ⬇️
...om/microsoft/azure/synapse/ml/cognitive/Face.scala 53.79% <0.00%> (-11.73%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 24.80% <0.00%> (-9.55%) ⬇️
.../azure/synapse/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) ⬇️
.../azure/synapse/ml/cognitive/FormRecognizerV3.scala 32.00% <0.00%> (-8.00%) ⬇️
.../azure/synapse/ml/cognitive/AnomalyDetection.scala 32.17% <0.00%> (-7.83%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da5f49...715bcf7. Read the comment docs.

@mhamilton723 mhamilton723 merged commit e4f0883 into microsoft:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants