Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix deep-learning test flakiness #1600

Merged

Conversation

serena-ruan
Copy link
Contributor

@serena-ruan serena-ruan commented Aug 5, 2022

Related Issues/PRs

None

What changes are proposed in this pull request?

fix deep-learning test flakiness

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1914960

@serena-ruan
Copy link
Contributor Author

/azp run

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Hey @serena-ruan 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #1600 (a22bba3) into master (adf1a61) will increase coverage by 3.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
+ Coverage   79.75%   83.10%   +3.34%     
==========================================
  Files         304      310       +6     
  Lines       15768    15823      +55     
  Branches      752      752              
==========================================
+ Hits        12576    13149     +573     
+ Misses       3192     2674     -518     
Impacted Files Coverage Δ
...ft/azure/synapse/ml/param/JsonEncodableParam.scala 12.85% <0.00%> (-51.43%) ⬇️
...rosoft/azure/synapse/ml/param/WrappableParam.scala 57.14% <0.00%> (-42.86%) ⬇️
...main/python/synapse/ml/io/http/JSONOutputParser.py 66.66% <0.00%> (-16.67%) ⬇️
...re/synapse/ml/cognitive/CognitiveServiceBase.scala 65.03% <0.00%> (-12.59%) ⬇️
...python/synapse/ml/io/http/SimpleHTTPTransformer.py 88.88% <0.00%> (-11.12%) ⬇️
...microsoft/azure/synapse/ml/codegen/Wrappable.scala 89.28% <0.00%> (-10.72%) ⬇️
.../azure/synapse/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) ⬇️
.../azure/synapse/ml/geospatial/AzureMapsTraits.scala 54.54% <0.00%> (-5.46%) ⬇️
...oft/azure/synapse/ml/codegen/DotnetWrappable.scala 83.87% <0.00%> (-5.38%) ⬇️
...re/src/main/python/synapse/ml/core/schema/Utils.py 67.10% <0.00%> (-5.27%) ⬇️
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan marked this pull request as ready for review August 5, 2022 09:24
@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yall the best

@mhamilton723 mhamilton723 merged commit 5a28740 into microsoft:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants