Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix translator endpoint and update all endpoints for gov regions #1623

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

serena-ruan
Copy link
Contributor

@serena-ruan serena-ruan commented Aug 19, 2022

Related Issues/PRs

No issues. There was a related IcM ticket.

What changes are proposed in this pull request?

For gov regions the cog service endpoint is different.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1937420

@github-actions
Copy link

Hey @serena-ruan 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1623 (dd085d6) into master (7e90d19) will decrease coverage by 1.25%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
- Coverage   83.72%   82.47%   -1.26%     
==========================================
  Files         292      292              
  Lines       15473    15482       +9     
  Branches      752      738      -14     
==========================================
- Hits        12955    12769     -186     
- Misses       2518     2713     +195     
Impacted Files Coverage Δ
...zure/synapse/ml/cognitive/DocumentTranslator.scala 19.44% <0.00%> (-0.28%) ⬇️
...re/synapse/ml/cognitive/CognitiveServiceBase.scala 78.52% <100.00%> (+0.90%) ⬆️
...soft/azure/synapse/ml/cognitive/SpeechToText.scala 84.90% <100.00%> (+0.29%) ⬆️
...ft/azure/synapse/ml/cognitive/TextTranslator.scala 81.27% <100.00%> (+0.07%) ⬆️
...ft/azure/synapse/ml/cognitive/AzureSearchAPI.scala 2.59% <0.00%> (-87.02%) ⬇️
...osoft/azure/synapse/ml/cognitive/AzureSearch.scala 9.35% <0.00%> (-78.42%) ⬇️
...soft/azure/synapse/ml/cognitive/TextToSpeech.scala 53.03% <0.00%> (-31.82%) ⬇️
...zure/synapse/ml/cognitive/AzureSearchSchemas.scala 71.42% <0.00%> (-28.58%) ⬇️
...oft/azure/synapse/ml/cognitive/SpeechSchemas.scala 80.00% <0.00%> (-20.00%) ⬇️
...zure/synapse/ml/stages/PartitionConsolidator.scala 93.61% <0.00%> (-2.13%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan merged commit 9f78bf0 into microsoft:master Aug 22, 2022
@serena-ruan serena-ruan deleted the serena/updateTranslator branch August 22, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants