Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove popups and hints in text area. #556

Closed
mafflin opened this issue Oct 28, 2016 · 23 comments
Closed

Remove popups and hints in text area. #556

mafflin opened this issue Oct 28, 2016 · 23 comments
Labels

Comments

@mafflin
Copy link

mafflin commented Oct 28, 2016

Please add option to disable annoying popups and alerts.

@bjnsn
Copy link

bjnsn commented Nov 1, 2016

If you're referring to this (which shows up when pausing typing), then I (politely) second the need for control.

screen shot 2016-10-31 at 4 57 58 pm

I thought this was the same as #544 but show_errors_inline doesn't seem to impact it.

@ghost
Copy link

ghost commented Nov 1, 2016

Absolutely agree. I had to manually edit the script to get rid of the annoying popup.
I also noticed that after recent changes my color scheme is broken now

@mafflin mafflin changed the title Remove stupid hints in text area!!!! Remove popups and hints in text area. Nov 1, 2016
@bypotatoes
Copy link

+1

@lorem--ipsum
Copy link

Who thought this could be a good idea ? If I wanted annoying popups with bright colors, I'd be using Webstorm.

@xaralis
Copy link

xaralis commented Nov 2, 2016

Please please, make this optional, the worst thing about it is that it makes your code lines jump back and forth and makes coding pretty creepy.

@roblav96
Copy link

roblav96 commented Nov 2, 2016

#thisfeaturesucks lol

@plwalters
Copy link

@ledz3pp can you share what you did to get rid of this?

@bjnsn
Copy link

bjnsn commented Nov 7, 2016

@PWKad Reverting to version 0.1.16 is one short-term option (worked for me).

@plwalters
Copy link

@bjnsn nice, I'll do that now as this is causing me to have a bunch of typos that I've never seen in Sublime before as the box shows and hides itself on in multi-line text mode.

@cdeutsch
Copy link

This makes sublime unusable. Revert

@KirillGrishin
Copy link

This is really annoying. I am pretty sure those who thought of it had best intentions in mind, but this is so annoying and distracting. Please please please, turn it off, or make optional.

@p-mcgowan
Copy link

p-mcgowan commented Nov 14, 2016

To anyone else looking for the solution: comment lines 26 - 29 (inclusive) in .../Packges/TypeScript/typescript/commands/error_info.py and restart sublime

...
if len(error_text) > 0:
  # if PHANTOM_SUPPORT:
  #       template = '<body><style>div.error {{ background-color: brown; padding: 5px; color: white }}</style><div class="error">{0}</div></body>'
  #       display_text = template.format(error_text)
  #       self.view.add_phantom("typescript_error", self.view.sel()[0], display_text, sublime.LAYOUT_BLOCK)
  self.view.set_status("typescript_error", error_text)

@caiogondim
Copy link

What happens when the package is updated?
Will we have to change the code after every update?

Constructive critique here:
This popup is def not "Sublime-like"
One thing that make Sublime users use it on the first place is it's focus on content
Please, consider putting this feature behind a flag

@p-mcgowan
Copy link

Yes, you will likely have to make the changes again after the update. PR-562 looks like it will solve this problem.

@drdanmorris
Copy link

Yes, please remove the annoying red inline error boxes. The TypeScript plugin is generally awesome, but this was an awful idea. I'll be doing the manual script hack for now (thanks p-mcgowan) until sanity has prevailed.

@speedy250
Copy link

I've been looking for this solution in all the wrong places; anywhere but the Microsoft plugin. Bizarre addition to the plugin, and thanks p-mcgowan for the hack.

@distinctdan
Copy link

+1 for removing this, although my main issue is that it's popping up for errors that aren't really errors. For example, I have a line that reads: public activeContainer: JQuery;, which causes the plugin to error with "Cannot find name JQuery". However, my project compiles fine (I'm using grunt to do my compilation). I've included JQuery's .d.ts. Also, I'm not using the /// comment at the top of my files because the modern ts compiler doesn't need it, not sure if that matters.

@plwalters
Copy link

Dan that's a completely separate issue sublime isn't picking up your typings or perhaps even the tsconfig but your build is

@abenhamdine
Copy link

It's done, you can clone the current repo into your Packages folder.

@distinctdan
Copy link

Yup, thanks @PWKad, at first I didn't realize I needed a tsconfig since I wasn't using the build system and I didn't want to mess up my grunt process, but adding one did the trick.

Now about the popup, I do like that it's showing useful information in a relevant context. I think the main issue is the presentation. It feels weird that it shifts the text, and it's kind of annoying that it's big and red and not closable if I press escape.

I think it may work better as a tooltip that hovers under the offending line instead of an inline thing. Someone else mentioned a delay, which could be good, and it would also be nice if the tooltip line-wrapped, so if it's a really long error, you don't have to scroll horizontally.

@distinctdan
Copy link

Hey, just wanted to say thanks for fixing this. The new error tooltips are great.

@madneon
Copy link

madneon commented Jun 17, 2017

What if I can't find TypeScript package and I have this annoying phantom popups? How to disable them?

@DanielRosenwasser
Copy link
Member

@madneon Just ensure you upgrade using package control. You shouldn't get this behavior anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests