Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow people to add stuff to tsconfig.json #1955

Closed
basarat opened this issue Feb 6, 2015 · 7 comments
Closed

Allow people to add stuff to tsconfig.json #1955

basarat opened this issue Feb 6, 2015 · 7 comments

Comments

@basarat
Copy link
Contributor

basarat commented Feb 6, 2015

I understand that tsconfig.json is read only for the typescript compiler. But whenever you guys start reading / modifying => writing tsconfig.json files would be great if you preserve additional keys. This would allow potential stuff like tslint errors to live in tsconfig.json.

Also I'm doing this : TypeStrong/atom-typescript#56

@mhegazy
Copy link
Contributor

mhegazy commented Feb 6, 2015

This has been the intention for the tsconfig work from the get go. It is just a json file you can extend it the way you like. This is also why the options are on a special mode:compileroptions and not just on the root. Obviously you want to have a top node as well that holds all your configurations e.g linterOptions to minimize chances of others stepping on your configurations.

@danquirk
Copy link
Member

danquirk commented Feb 6, 2015

Is something actually broken here?

@basarat
Copy link
Contributor Author

basarat commented Feb 6, 2015

Is something actually broken here?

no this was a question. Thanks!

@basarat basarat closed this as completed Feb 6, 2015
@basarat
Copy link
Contributor Author

basarat commented Feb 13, 2015

@basarat
Copy link
Contributor Author

basarat commented Feb 13, 2015

@park9140

@johnnyreilly
Copy link

Thanks for the heads up @basarat

@basarat
Copy link
Contributor Author

basarat commented Mar 10, 2015

@mhegazy I see you are using https://github.com/Microsoft/TypeScript/blame/master/src/server/editorServices.ts#L262 formatCodeOptions so I will rename mine to match

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants