Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quick fix for XXX has or is using name 'Foo' from external module "../bar" but cannot be named #22132

Closed
mhegazy opened this issue Feb 22, 2018 · 1 comment
Closed

Add quick fix for XXX has or is using name 'Foo' from external module "../bar" but cannot be named #22132

mhegazy opened this issue Feb 22, 2018 · 1 comment
Assignees
@weswigham
Labels
Domain: Declaration Emit The issue relates to the emission of d.ts files Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript
Milestone
TypeScript 3.0

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Feb 22, 2018

A fix will need to:

  1. Import the missing type
  2. Add an explicit type annotation to the declaration that is causing the error using the imported type

More discussion in #9944
@mhegazy mhegazy added Suggestion An idea for TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. labels Feb 22, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Feb 22, 2018
@mhegazy mhegazy modified the milestones: TypeScript 2.8, TypeScript 2.9 Mar 9, 2018
@weswigham weswigham added the Domain: Declaration Emit The issue relates to the emission of d.ts files label Mar 22, 2018
@mhegazy mhegazy mentioned this issue Mar 29, 2018
Closed
@weswigham weswigham mentioned this issue May 11, 2018
Merged
@mhegazy mhegazy closed this as completed May 17, 2018
@mhegazy
Copy link
Contributor Author

mhegazy commented May 17, 2018

With #24071 in, this should not be needed any longer

@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weswigham weswigham

Labels
Domain: Declaration Emit The issue relates to the emission of d.ts files Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 3.0
Development

No branches or pull requests
2 participants
@weswigham @mhegazy