Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better responses for TSX getSyntacticClassifications #5582

Closed
basarat opened this issue Nov 10, 2015 · 3 comments · Fixed by #5583
Closed

Better responses for TSX getSyntacticClassifications #5582

basarat opened this issue Nov 10, 2015 · 3 comments · Fixed by #5583
Labels
Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Milestone
TypeScript 1.8

Comments

@basarat
Copy link
Contributor

basarat commented Nov 10, 2015

Currently its all identifier as shown below:

image

(I haven't wired up the highlight response with the syntactic response so don't mind the colors just yet 🌹)

Would be great if it was something like TSX identifier etc. Would allow me to implement tag matching better.

refs #5545
@DanielRosenwasser DanielRosenwasser added the Suggestion An idea for TypeScript label Nov 10, 2015
@basarat
Copy link
Contributor Author

basarat commented Nov 10, 2015

I'll PR soon 🌹

image

@basarat basarat mentioned this issue Nov 10, 2015
Merged
@basarat
Copy link
Contributor Author

basarat commented Nov 10, 2015

PR sent : #5583 🌹

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 11, 2015
@mhegazy mhegazy added this to the TypeScript 1.8 milestone Nov 11, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Nov 11, 2015

thanks @basarat

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 1.8
Development

Successfully merging a pull request may close this issue.

tsx : support tags in language service semantic tokenizer
3 participants
@basarat @DanielRosenwasser @mhegazy