Shorthand property #1127
Shorthand property #1127
Conversation
Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/emitter.ts
| @@ -110,7 +110,8 @@ module ts { | |||
| getAliasedSymbol: resolveImport, | |||
| isUndefinedSymbol: symbol => symbol === undefinedSymbol, | |||
| isArgumentsSymbol: symbol => symbol === argumentsSymbol, | |||
| hasEarlyErrors: hasEarlyErrors | |||
| hasEarlyErrors: hasEarlyErrors, | |||
| resolveEntityNameForShortHandPropertyAssignment: resolveEntityNameForShortHandPropertyAssignment, | |||
There was a problem hiding this comment.
seems like an extremely specific operation to export from the checker. Why can't we export our normal members, and they check once they were called if they were called on a shorthand property assignment?
There was a problem hiding this comment.
We can certainly do that. I was just trying to minimize the exposure of the entire resolveEntityName since we only need it in the case of short-hand. Also we have to manually pass in the meaning flag
There was a problem hiding this comment.
What about getSymbolInfo? That should eventually call resolveEntityName
There was a problem hiding this comment.
the problem here is that we have two meaning for the node. so when you ask getSymbolInfo, which symbol do you want, the value or the declaration.
There was a problem hiding this comment.
This duality is common in other languages (like VB). For example, in a VB query, an identifier can be a query variable, or the name of something referenced. This is one of the reasons that roslyn separates out the concept of 'GetDeclaredSymbol' (to give you info about the thing being declared) versus 'GetSymbolInfo' (which will give you info about something being referenced).
There was a problem hiding this comment.
If I understand what Cyrus is saying, this duality can be dealt with in the services layer, possibly by making two calls to the typeInfoResolver.
There was a problem hiding this comment.
In that case, then should we do something similar to rosyln and have a function call getDeclaredSymbol in the case we want a declaration symbol instead of value one
|
I will be having separate CR for using shorthand property assignment in compiler |
|
👍 |
Conflicts: src/compiler/checker.ts
Implementation of short-hand property assignment in compiler and language service. Initial conformance tests are added and more tests for fourslash will be added.