CyrusNajmabadi
Follow
Pinned
8,437 contributions in the last year
Activity overview
Contributed to
dotnet/roslyn,
CyrusNajmabadi/lang-design,
dotnet/csharplang
and 12 other
repositories
Contribution activity
March 2023
Created 439 commits in 2 repositories
Created a pull request in dotnet/roslyn that received 43 comments
Walk green tree to avoid excessive allocations in reported trace
This is called for every method (from SourceOrdinaryMethodSymbol) and accounts for 10% of allocations in traces we are looking at:
+46
−24
•
43
comments
Opened 50 other pull requests in 2 repositories
dotnet/roslyn
41
merged
4
open
3
closed
- Remove abstract method that always returns the same value
- Create a new solution folder for all things language-server related
- Do not use VS specific completion kinds in core LSP protocol layer
- Simplify diagnostic check
- Add test
- Reduce allocations in diagnostic analyzer management system.
- Do not capture project/solution/compilation data in designer-attribute-scanning.
- Move off of options for encoding ephemeral state in inline-hints
- Update 'use auto property' to be a symbol-start/end analyzer instead of a semantic-model analyzer.
- Code changes to allow 'using static unsafe'
- Remove unused state form TypeofBinder and GetTypeBinder.
- Improve error recovery while parsing switch expressions.
- Support generating records in syntax generator
- Search a smaller scope when looking for references to a local symbol
- Improve perf of resolving local symbol keys
- Do not make cross-process calls to try to find references to local symbols
- Remove descendent node tracking from SyntaxEditor
- Remove document from lsp misc workspace when it is found in normal workspace
- Do not use the Lsp-Misc workspace in VS scenarios
- Add information to help us determine which misc workspace a file belongs to.
- Disallow pointers inside generic type-arguments unless in an unsafe context (in C#12 and beyond).
- Better parser error recovery when encountering a open generic name.
- WIP: Use a common mechanism so Taggers access the main thread at the same time.
- Fix error location in test
- Simplify tests
- Some pull requests not shown.
dotnet/csharplang
2
merged
Reviewed 67 pull requests in 4 repositories
dotnet/roslyn
25 pull requests
- Remove abstract method that always returns the same value
- [Lightbulb Perf] Add support for prioritized diagnostic computation requests in OOP
- Do not use VS specific completion kinds in core LSP protocol layer
- Enum base list completions
- Exclude non-local diagnostics by default in legacy test framework for analyzer/code fix unit tests
- Reduce allocations in diagnostic analyzer management system.
- Code changes to allow 'using static unsafe'
- Move off of options for encoding ephemeral state in inline-hints
- Make Document Outline computation and update asynchronous.
- Improve error recovery while parsing switch expressions.
- Collection literals natural type
- Improve props in readonly struct
- Fix unimported completions show in places where they should not be
- Update AbstractEditorFactory to implement IVsEditorFactoryChooser
- Update 'use auto property' to be a symbol-start/end analyzer instead of a semantic-model analyzer.
- Remove unused state form TypeofBinder and GetTypeBinder.
- Support generating records in syntax generator
- Fix CSharpMakeStructMemberReadOnlyDiagnosticAnalyzer to report local diagnostic
- Rename codefix predefined name
- Search a smaller scope when looking for references to a local symbol
- Add tests for local/non-local diagnostic classification for accessor block
- Remove descendent node tracking from SyntaxEditor
- Improve perf of resolving local symbol keys
- Implement LSP inlay hints
- Compute TextChange based on syntax instead of text
- Some pull request reviews not shown.
dotnet/csharplang
3 pull requests
dotnet/runtime
1 pull request
dotnet/roslyn-sdk
1 pull request
Created an issue in dotnet/roslyn that received 1 comment
Investigate ways to potentially speed up ForAttributeWithMetadataName
Examples of things we could potentially do (without a public api change): have the compiler store information if any attribute was found within a …
1
comment
Opened 2 other issues in 1 repository
Answered 6 discussions in 2 repositories
dotnet/roslyn
dotnet/roslyn
-
Are aliases supposed to work in `(Alias)QualifiedName`s?
This contribution was made on Mar 20
-
Can a source generator reference itself as an analyzer?
This contribution was made on Mar 18
-
Can a source generator reference itself as an analyzer?
This contribution was made on Mar 18
-
Should "Introduce a local variable" work with top-level statements?
This contribution was made on Mar 11
-
cascade ISourceGenerator
This contribution was made on Mar 7
dotnet/csharplang
dotnet/csharplang
-
Could possibly call to method annotated with [DoesNotReturn] spare you writing return statement?
This contribution was made on Mar 21