Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use object type #15124

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Use object type #15124

merged 1 commit into from
Apr 14, 2017

Conversation

falsandtru
Copy link
Contributor

Fixes #13493

@falsandtru
Copy link
Contributor Author

@sandersn @RyanCavanaugh @mhegazy Please review.

@falsandtru
Copy link
Contributor Author

@sandersn @RyanCavanaugh @mhegazy @DanielRosenwasser

@sandersn
Copy link
Member

Let's swap @sandersn with @rbuckton. I'm not fluent enough with runtime semantics to be a useful reviewer here.

@falsandtru
Copy link
Contributor Author

I see, thanks.

@falsandtru
Copy link
Contributor Author

@rbuckton Could you?

rbuckton
rbuckton approved these changes Apr 14, 2017
View reviewed changes
Copy link
Member

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rbuckton rbuckton merged commit 28c0eed into microsoft:master Apr 14, 2017
@falsandtru
Copy link
Contributor Author

Thanks!

@falsandtru falsandtru deleted the lib.d.ts/object branch April 14, 2017 16:05
mhegazy added a commit that referenced this pull request Apr 19, 2017
@mhegazy
Revert changes to WeakSet defitions adding object constraint
552f1d8 
This reverts the changes to WeakSet done in #15124 to avoid breaks in existing @types packages like @types/lodash
@mhegazy mhegazy mentioned this pull request Apr 19, 2017
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rbuckton rbuckton rbuckton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@falsandtru @sandersn @rbuckton @msftclas