Fix runtests-browser in gulp, including RWC, remove into-stream #17540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have we upgraded to using gulp-sourcemaps 2.x yet? We were doing a lot of things to work around sourcemap paths that can be resolved by using 2.x with the 'destPath' option. |
|
@rbuckton we're on |
ghost
approved these changes
Aug 1, 2017
GulajavaMinistudio
added a commit
to GulajavaMinistudio/TypeScript
that referenced
this pull request
Aug 2, 2017
Fix runtests-browser in gulp, including RWC, remove into-stream (microsoft#17540)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17010
Browserify/gulp-typescript had taken some minor version bumps in the last year that made what we were doing before ever-so-slightly completely nonfunctional (mostly a more correct handling of the current directory and paths). It's now better and, additionally, does not rely on
into-stream.Also adds the long timeout we specify for RWC tests directly into the RWC tests themselves, this way the timeout works in the browser (meaning you can debug RWC tests in the browser, like I'm about to).