Minimal implementation of Decorators #2399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can you add testcases for sourcemaps |
| @@ -100,11 +100,18 @@ module ts { | |||
| let globalIterableType: ObjectType; | |||
|
|
|||
| let anyArrayType: Type; | |||
| let globalTypedPropertyDescriptorType: ObjectType; | |||
| let globalClassDecoratorType: ObjectType; | |||
| let globalClassAnnotationType: ObjectType; | |||
There was a problem hiding this comment.
let's try to limit the number of concepts users have to deal with and keep the decorator only falvor.
rbuckton
added a commit
that referenced
this pull request
Mar 25, 2015
|
Merged manually into master |
Closed
| @@ -4968,14 +5113,15 @@ module ts { | |||
|
|
|||
| function parseDeclaration(): ModuleElement { | |||
| let fullStart = getNodePos(); | |||
| let decorators = parseDecorators(); | |||
There was a problem hiding this comment.
This allows you to use decorators before the export keyword.
@decorator export default class Foo {}But if this is the spec we're following, this isn't actually included in the grammar. Only:
export default @decorator class Foo {}If you can confirm this is a mistake, I'll open an issue and/or PR if you'd like.
There was a problem hiding this comment.
Subscribers, discussion is being had here wycats/javascript-decorators#7 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal implementation of Decorators