Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of watching individual script infos, watch the node modules folder for script infos in node modules #26135

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Aug 1, 2018

Newer version of #23596
Fixes #27039

@sheetalkamat sheetalkamat force-pushed the watchDirectoryOfNodeModulesScriptInfo branch from 76339de to 2c58d3d Compare August 1, 2018 23:31
@RyanCavanaugh
Copy link
Member

@sheetalkamat what's the status on this one?

@sheetalkamat
Copy link
Member Author

@RyanCavanaugh As per our offline sync, since this is just theorotical and there isnt any issue reported for this, we will wait for this.

@sheetalkamat sheetalkamat force-pushed the watchDirectoryOfNodeModulesScriptInfo branch from 2c58d3d to e2edb69 Compare September 13, 2018 20:49
@sheetalkamat
Copy link
Member Author

Thanks to @andy-ms to see get this data for Linux. It is very minimal improvement and not much on Linux but helps a lot with windows when opening file from repro of #27039
With tsnext:

Info 952  [15:53:37.896] 	FileName: /home/andy/sample/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: /home/andy/sample/DatingApp/DatingApp-SPA
Info 952  [15:53:37.896] 		Projects: /home/andy/sample/DatingApp/DatingApp-SPA/tsconfig.json
Perf 952  [15:53:37.896] 2::open: async elapsed time (in milliseconds) 4386.3848

With this PR:

Info 136  [15:56:17.95] Open files: 
Info 136  [15:56:17.95] 	FileName: /home/andy/sample/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: /home/andy/sample/DatingApp/DatingApp-SPA
Info 136  [15:56:17.95] 		Projects: /home/andy/sample/DatingApp/DatingApp-SPA/tsconfig.json
Perf 136  [15:56:17.95] 2::open: async elapsed time (in milliseconds) 4359.4610

On Windows::
With tsnext:

Info 977  [16:32:37.785] 	FileName: c:/temp/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: c:/temp/DatingApp/DatingApp-SPA
Info 977  [16:32:37.785] 		Projects: c:/temp/DatingApp/DatingApp-SPA/tsconfig.json
Perf 977  [16:32:37.785] 2::open: async elapsed time (in milliseconds) 14705.2836

With this PR:

Info 161  [16:38:10.222] -----------------------------------------------
Info 161  [16:38:10.222] Open files: 
Info 161  [16:38:10.222] 	FileName: c:/temp/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: c:/temp/DatingApp/DatingApp-SPA
Info 161  [16:38:10.223] 		Projects: c:/temp/DatingApp/DatingApp-SPA/tsconfig.json
Perf 161  [16:38:10.223] 2::open: async elapsed time (in milliseconds) 9974.4252

@sheetalkamat
Copy link
Member Author

@RyanCavanaugh It is ready to be reviewed and merged

@sheetalkamat sheetalkamat changed the title [WIP] Instead of watching individual script infos, watch the node modules folder for script infos in node modules Instead of watching individual script infos, watch the node modules folder for script infos in node modules Sep 13, 2018
@sheetalkamat sheetalkamat merged commit b563978 into master Sep 14, 2018
@sheetalkamat sheetalkamat deleted the watchDirectoryOfNodeModulesScriptInfo branch September 14, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants