-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics for relation cache size #30999
Conversation
@@ -114,6 +114,9 @@ namespace ts { | |||
getIdentifierCount: () => sum(host.getSourceFiles(), "identifierCount"), | |||
getSymbolCount: () => sum(host.getSourceFiles(), "symbolCount") + symbolCount, | |||
getTypeCount: () => typeCount, | |||
getAssignabilityCacheSize: () => assignableRelation.size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on doing it this way?
getRelationCacheSizes(): {
assignable: assignableRelation.size,
identity: identityRelation.size,
subtype: subtypeRelation.size
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No love for comparablility I see. :sad:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanCavanaugh seems like a fine idea. do you want to reduce the number of calls when getting perf diagnostics, or reduce the API surface? (or both)
@DanielRosenwasser lolololololol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, both (seems like you'd rarely want only one of them and it's basically free to query)
No description provided.