Adding OrbitView control #1160
Adding OrbitView control #1160
Conversation
|
Could this be accomplished by restyling the ListView? https://web.archive.org/web/20080214170102/http://www.beacosta.com/blog/?p=40 |
|
@skendrot, I'm sure it can. Any reason why it should? |
|
Perhaps a more generic name like OrbitView, or NetworkView. Also it would be great to have Pinch to Zoom support, where elements maintain their size, but the spacing between items increases or decreases. Support for animations if an item is selected programmatically, so you can animate zooming close to an item, or away from it. The view changes to show multiple items if multi-select is enabled. An option to display a flyout beside the selected object, instead of having to have a static detail view to the side. |
|
Thanks for the feedback @mdtauk. I think all those suggestions are great, and I can see them as potential features for a v2. We should focus on having a solid simple control for initial release. On the name, OrbitView is a great suggestion. Let me see if there is a way to do polling for the names |
|
Trying something new. Name poll (add your reaction to vote for the appropriate item):
|
|
Looks like people like OrbitView the most. Unless there is no uproar in the next few days, I'll change the name to OrbitVIew :) |
| var control = element as OrbitViewItemControl; | ||
| var orbitViewItem = item as OrbitViewItem; | ||
| FrameworkElement orbitViewElement = null; | ||
|
|
There was a problem hiding this comment.
can we declare of possible types here using as so we don't do is followed by as ?
There was a problem hiding this comment.
I'm a big fan of is because it is more descriptive, as should be cast.
|
|
||
| using Microsoft.Toolkit.Uwp.UI.Controls; | ||
| using System; | ||
| using System.Collections.Generic; |
There was a problem hiding this comment.
There are a lot of unused references, please remove it
| /// </summary> | ||
| public sealed partial class OrbitViewPage : Page | ||
| { | ||
| ObservableCollection<DeviceItem> Devices = new ObservableCollection<DeviceItem>(); |
There was a problem hiding this comment.
Devices and random variables aren't following the toolkit naming convention
| Devices.Add(new DeviceItem() { Distance = random.Next(1, 10) / 10f, Label = "My Phone", Symbol = Symbol.CellPhone }); | ||
| } | ||
|
|
||
| private void itemInvoked(object sender, OrbitViewItemClickedEventArgs e) |
There was a problem hiding this comment.
Event name should start with a capital letter
| @@ -0,0 +1,90 @@ | |||
| <Page | |||
There was a problem hiding this comment.
Please use Xaml styler extension in any xaml file. (once you save any xaml file it will apply our styles)
| using Windows.UI.Xaml.Media; | ||
| using Windows.UI.Xaml.Navigation; | ||
|
|
||
| // The Blank Page item template is documented at https://go.microsoft.com/fwlink/?LinkId=234238 |
There was a problem hiding this comment.
Please remove this comment
| if (_panel == null && ItemsPanelRoot != null) | ||
| { | ||
| _panel = ItemsPanelRoot as OrbitViewPanel; | ||
| _panel.ItemArranged += OrbitViewPanel_ItemArranged; |
There was a problem hiding this comment.
Should we unsubscribe from this events before subscribe as it seems to me that this function is will repeat.
| var control = element as OrbitViewItemControl; | ||
| var orbitViewItem = item as OrbitViewItem; | ||
| FrameworkElement orbitViewElement = null; | ||
|
|
There was a problem hiding this comment.
I'm a big fan of is because it is more descriptive, as should be cast.
| } | ||
|
|
||
| /// <summary> | ||
| /// Identifies the <see cref="DistanceProperty"/> property |
There was a problem hiding this comment.
Documentation here should refer to Distance not DistanceProperty, please apply this comment on this file
| /// Identifies the <see cref="DistanceProperty"/> property | ||
| /// </summary> | ||
| public static readonly DependencyProperty DistanceProperty = | ||
| DependencyProperty.Register("Distance", typeof(double), typeof(OrbitViewItem), new PropertyMetadata(0.5)); |
There was a problem hiding this comment.
Also please use nameof(Distance) instead of "Distance" also please apply to the rest of the file :)
| /// <summary> | ||
| /// Identifies the <see cref="IsClickEnabledProperty"/> property | ||
| /// </summary> | ||
| public static readonly DependencyProperty IsClickEnabledProperty = |
There was a problem hiding this comment.
Same as other property the documentation is refereing to wrong property and please use nameof
From love at Build 2017
Issue: #1154