Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BladeItem to be an Expander #1248

Merged
merged 2 commits into from
Jun 27, 2017

Conversation

skendrot
Copy link
Contributor

Based on changes from #1049 change the BladeItem to be an Expander to control is expand and collapse states

Copy link
Contributor

@azchohfi azchohfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmetulev nmetulev merged commit 52bbdb7 into CommunityToolkit:dev Jun 27, 2017
@Odonno
Copy link
Contributor

Odonno commented Jun 28, 2017

@skendrot I think it can be even more beautiful with horizontal Expander. What do you think?

The orientation mode for Expander is not currently available, so we can stay with the current implementation for now.

@skendrot
Copy link
Contributor Author

Not sure what you mean @Odonno

@Odonno
Copy link
Contributor

Odonno commented Jun 28, 2017

@skendrot Something like this accordion but horizontally. And reusing the Expander control by setting horizontal mode so you can expand/collapse by clicking on a "column".

https://help.syncfusion.com/uwp/sfaccordion/Appearence-and-Styling-images/appearence-and-styling-img1.jpeg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants