Fix typo #1006
Closed
Fix typo #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Some of the proposed changes are incorrect. I'll accept the valid ones. Thanks. |
oldnewthing
reviewed
Mar 20, 2020
| @@ -21,7 +21,7 @@ For an intro to casting, see the *Basic Media Casting Sample*. | |||
| **Scenario 1: Media Element Casting 101:** | |||
| Press the *Cast* button next to the progress bar in the video element. Select the device you'd like to cast to. | |||
|
|
|||
| This is an example of the built in casting that comes with the media element transport controls. This will enable casting to Miracast, DLNA, and Bluetooth devices. | |||
| This is an example of the built-in casting that comes with the media element transport controls. This will enable casting to Miracast, DLNA, and Bluetooth devices. | |||
| - Create an ad control to show display ads programatically | ||
| - Create an ad control to show interstitial video ads programatically | ||
| - Create an ad control to show display ads programmatically | ||
| - Create an ad control to show interstitial video ads programmatically |
| @@ -45,7 +45,7 @@ In the code-behind for this scenario, an **AudioGraph** is created with three no | |||
| This scenario shows how to generate and route audio data into an audio graph from custom code. Press the *Generate Audio* button to start generating audio from custom code. | |||
| Press *Stop* to stop the audio. | |||
|
|
|||
| In the code-behind for this scenario an **AudioGraph** is created with two nodes: an **AudioFrameInputNode** that represents the custom audio generation code and which is connected to an **AudioDeviceOutputNode** representing the default output device. The **AudioFrameInputNode** is created with the same encoding as the audio graph so that the generated audio data has the same format as the graph. Once the audio graph is started, the **QuantumStarted** event is raised by the audio graph whenever the custom code needs to provide more audio data. The custom code creates a new **AudioFrame** object in which the audio data is stored. The example accesses the underlying buffer of the **AudioFrame**, which requires an **unsafe** code block, and inserts values from a sine wav into the buffer. The **AudioFrame** containing the audio data is then added to the **AudioFrameInputNode** list of frames ready to be processed, which is then consumed by the audio graph and passed to the audio device output node. | |||
| In the code-behind for this scenario an **AudioGraph** is created with two nodes: an **AudioFrameInputNode** that represents the custom audio generation code and which is connected to an **AudioDeviceOutputNode** representing the default output device. The **AudioFrameInputNode** is created with the same encoding as the audio graph so that the generated audio data has the same format as the graph. Once the audio graph is started, the **QuantumStarted** event is raised by the audio graph whenever the custom code needs to provide more audio data. The custom code creates a new **AudioFrame** object in which the audio data is stored. The example accesses the underlying buffer of the **AudioFrame**, which requires an **unsafe** code block, and inserts values from a sine wave into the buffer. The **AudioFrame** containing the audio data is then added to the **AudioFrameInputNode** list of frames ready to be processed, which is then consumed by the audio graph and passed to the audio device output node. | |||
There was a problem hiding this comment.
This change is okay (wav->wave).
|
|
||
| The code-behind for this scenario uses just two nodes. An **AudioFileInputNode** and a **AudioDeviceOutputNode**. The effects are initialized and then added to the **EffectDefinitions** list of the file input node. | ||
|
|
||
| **Scenario 6: Custom Effects:** | ||
| This scenario demonstrates how to create an custom audio effect and then using it in an audio graph. Press the *Load File* button to select an audio file to play. Press *Start Graph* to begin playback of the file with the custom effect. | ||
|
|
||
| The custom effect for this scenario is defined in a single file, CustomEffect.cs, that is included in its own project. The class implemented in this file, AudioEchoEffect, implements the **IBasicAudioEffect** interface which allows it to be used in an audio graph. The actual audio processing is implemented in the **ProcessFrame** method. The audio graph calls this method and passes in a **ProcessAudioFrameContext** object which provides access to **AudioFrame** objects representing the input to the effect and the output from the effect. The effect implements a simple echo by storing samples from the input frame in a buffer and then adding the samples previously stored in the buffer to the current input samples and then inserting thos values into the output frame buffer. | ||
| The custom effect for this scenario is defined in a single file, CustomEffect.cs, that is included in its own project. The class implemented in this file, AudioEchoEffect, implements the **IBasicAudioEffect** interface which allows it to be used in an audio graph. The actual audio processing is implemented in the **ProcessFrame** method. The audio graph calls this method and passes in a **ProcessAudioFrameContext** object which provides access to **AudioFrame** objects representing the input to the effect and the output from the effect. The effect implements a simple echo by storing samples from the input frame in a buffer and then adding the samples previously stored in the buffer to the current input samples and then inserting those values into the output frame buffer. |
|
The only ones that survived are the ones in AudioCreation. (Advertising is being archived.) |
oldnewthing
added a commit
that referenced
this pull request
Mar 25, 2020
* 360VideoPlayback: Align configurations, reset shader between stages #791 #942 * Clipboard: Add history and roaming scenarios, improve delay-rendering, clipboard change reporting, error-handling. * CustomSerialDeviceAccess: Fix RequestToSendXOnXOff #1085 * Holographic samples support HoloLens 2 device and emulator * HolographicFaceTracking: Fix comment about NV12 #834 * HolographicVoiceInput: Fix release build * PlayReady: Don't create container twice #1159 * RadioManager: Clarify require capabilities #1165 * SpeechRecognitionAndSynthesis: Clarify which scenarios require internet access #725, Update permission links #1002 * UserActivity: Fix protocol navigation #1176 * XamlMasterDetail: Fix navigation problems #344 #345 * SharedContent: Default.rd.xml fixes #950 * Miscellaneous typos: AdvancedCasting #1006, AudioCreation #1006, BluetoothAdvertisement #898, BluetoothRfcommChat #1139, Json #404, Nfc #1039, XamlBind #1169 #1182 * Add missing Line Display sample to TOC #704 * All C++ samples now build in both VS2017 and VS2019. * All C++/WinRT samples upgraded to C++/WinRT 2.0 #1179 * New: Clipboard (C++/WinRT), JapanesePhoneticAnalysis (C++/WinRT) * Archived: Advertising, CallerId, Clipboard (C++/CX and VB), CommunicationBlockAndFilter, PhoneCall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.