Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recreate expired files - overwrite existing files #2091

Merged
merged 3 commits into from
May 17, 2018
Merged

Conversation

hermitdave
Copy link
Contributor

Issue: #

PR Type

What kind of change does this PR introduce?

<- Bugfix >

What is the current behavior?

The cache instead of overwriting an existing file, recreates the file and then downloads the data. This would mean that in case of data / network failure, the cached copy has been destroyed and there is no newer copy to return to the consumer

What is the new behavior?

The cache does not overwrite existing file. Instead existing file if expired is passed to download method which overwrites it if successful.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@hermitdave hermitdave requested a review from nmetulev May 12, 2018 21:57
@azchohfi azchohfi merged commit c434a6e into master May 17, 2018
@azchohfi azchohfi deleted the HD-Cache branch May 17, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants