Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Win32 packages in a new solution #2189

Merged
merged 4 commits into from
Jun 4, 2018
Merged

Move Win32 packages in a new solution #2189

merged 4 commits into from
Jun 4, 2018

Conversation

nmetulev
Copy link
Contributor

Issue: #2188

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@nmetulev nmetulev requested review from rjmurillo and removed request for WilliamABradley May 31, 2018 21:40
@IbraheemOsama
Copy link
Member

Would we have a problem in packaging if we removed this project from the main one ? (I don't know just a question :) )

@nmetulev
Copy link
Contributor Author

nmetulev commented Jun 1, 2018

@IbraheemOsama, I made sure the new solution is also packaged and generates the nugets.

@nmetulev nmetulev merged commit 2d034f0 into master Jun 4, 2018
@nmetulev nmetulev deleted the nmetulev/reorg branch June 4, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants