Moved SignInFailed event to MicrosoftGraphService #2205
Conversation
…se SignInFailed event instead
|
The changes are to suppress the MsalServiceException exceptions in |
docs/graph/PeoplePicker.md
Outdated
| @@ -45,6 +45,11 @@ MicrosoftGraphService.Instance.Initialize( | |||
| MicrosoftGraphEnums.ServicesToInitialize.UserProfile, | |||
| PeoplePicker.RequiredDelegatedPermissions | |||
| ); | |||
|
|
|||
| MicrosoftGraphService.Instance.SignInFailed += (sender, e) => | |||
There was a problem hiding this comment.
Instead of adding this sample in every graph control docs, can you add it once to the Microsoft graph sample page
There was a problem hiding this comment.
This is not only making the property obsolete, it is breaking the functionality. The SignInFailed event from the AadLogin class is never called anymore, so this is not only now obsolete, it is broken. Obsolete means "don't use anymore, will stop working", but this is broken now.
…ing integration works smoothly
|
@azchohfi Yes, I missed that, the event AadLogin.SignInFailed can be called now if it's registered. |
|
Buddies, any further feedback for this PR? Just let us know if there's any changes to be processed, thank you. |
Issue: #
#2171
PR Type
What kind of change does this PR introduce?
Bugfix
Sample app changes
PR Checklist
Please check if your PR fulfills the following requirements:
Other information