Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Microsoft SourceLink #2215

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Switch to Microsoft SourceLink #2215

merged 3 commits into from
Jun 7, 2018

Conversation

clairernovotny
Copy link
Member

@clairernovotny clairernovotny commented Jun 7, 2018

Issue: #

PR Type

What kind of change does this PR introduce?

Switches to the newer Microsoft Sourcelink packages:
https://github.com/dotnet/sourcelink

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Sourcelink has been moved to dotnet/sourcelink. One of the prereq's is MSBuild 15.7, and the hosted pools now have that installed.

@nmetulev
Copy link
Contributor

nmetulev commented Jun 7, 2018

Is this related to #2088?

@clairernovotny
Copy link
Member Author

Didn't see that one, but we already have had it for a while using the older package. This is updating to use the latest packages.

@clairernovotny
Copy link
Member Author

Confirmed working by virtue of this being in the nuspec now with the new tooling
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants