-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check container recreation in OnBackgroundActivated #2633
Conversation
this should be on the main readme i think. |
Thanks Bart!! Did a bit of research where this came from, and saw this was initially added in PR #1606, won't this lead to regression in case the app is terminated? |
Since the background task is in-process, it's terminated as well and can't re-activate a terminated app. Am I correct? I've tested following cases (manually through VS lifecycle states):
All worked fine. |
Looks like there's one more step to be tested (see issue). I'll look at it tonight, can stay open for now. |
Quick update: making progress on this, but checking a few more items to see for the best solution. Out of town for 2 days, so picking this up again over the weekend. |
@bartlannoeye, what's the status for this pr? |
Best thing we can do for now, focusing our time on v7 to fix this correctly.
Hey @sibille, the complexity of trying to make it work with the current release, combined with multiple events (attending and/or speaking) resulted in taking a bit longer. I've done a "best-effort" fix which handles 95% of all use cases and described the last edge case (which should rarely happen) in the linked issue. We'll have to take this last one in our next Prism release. It's an improvement over the current code in WTS, so if the team agrees, I would suggest to merge this PR and we'll do our best to get the next release out the door asap. |
Thanks @bartlannoeye, sounds good to me! |
PR checklist
Quick summary of changes