Updates to styling including font style and hiding GViewer toolbar buttons

[daveaglick]

First off, thank you so much for making MSAGL open source, and even more for changing to an MIT license! It's a great library that fills an important niche and I think developers have been avoiding it in the past because of the murky licensing and purchasing options.

This PR is a collection of styling updates.

The biggest one is the addition of font styles. I implemented it similarly to other Node styling in that there is now a Microsoft.Msagl.Drawing.FontStyle enum instead of a direct dependency on System.Drawing. However, I only implemented support for the new font styling within the GDI control. Implementing font styling for the WPF control will be harder because there is no single property to change. In WPF, "boldness" is handled via weight, italics is handler via the WPF FontStyle static class, etc.

I also added flags to hide a couple additional GViewer toolbar buttons.

I also removed a Console.WriteLine() call in LayoutHelpers.CalculateLayout(). This was causing problems for me because in an application using MSAGL that either traps, displays, or passes on console output, these messages start to add noise. This one was appearing constantly for me. I did notice there were several other uses of Console.WriteLine(), specifically in some of the layout engines - maybe those should be removed as well and a logging infrastructure put in place instead?

[msftclas]

Hi @daveaglick, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[levnach]

Dave, thank you for the PR! I have one concern. I suspect that after your change old versions of MSAGL files would not load. Please use GraphReader.TokenIs method to check that the FontStyle XML node is present in the file that is being loaded, and if it is not present then the label should be created with the default style.
I agree with your comment on WriteLine()

[daveaglick]

That makes perfect sense. Just committed a patch (hopefully I used GraphReader.TokenIs() correctly).

Also, it may be a day or two before I have a signed CLA ready for you. My employer's legal department has requested to review it.

[birbilis]

So, does the MSBOT detect when CLA signing has been done and update such pending requests with that info/label?

[rassilon]

The MSBOT does detect when the CLA signing occurs as long as you fill out the information correctly since it is related to your github account, IIRC. My open PRs got turned into cla-signed from cla-required. New PRs of mine now get cla-already-signed.

Fyi,
Bill

[daveaglick]

Yeah, about that... I actually haven't signed the CLA yet, and at this point I suspect I'll need to do a merge on my PR to get it up to date before it's accepted.

Sorry for the delay - unfortunately, the CLA requires employer participation and mine is currently "reviewing" the agreement (and has been for a while). I have no idea when I'll get the go-ahead to sign, though I've at least been told they'll support it eventually.

Once I do get it signed, I'll do a quick catch-up on the PR.

[birbilis]

btw, regarding Console.WriteLine, wasn't there a Debug.WriteLine that gets ignored at production builds?

https://support.microsoft.com/en-us/kb/815788
says "If the solution configuration type is Release, the Debug class output is ignored."

[msftclas]

@daveaglick, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

[daveaglick]

"Thanks for signing the contribution license agreement so quickly" Lol.

It's been long enough that my branch is now way behind. I'm working on a rebase and should have this PR updated soon.

[daveaglick]

Okay, should be good to go now.

[levnach]

Hi Dave, I am getting this error when building your sources.

C:\dev\git\GraphLayout\tools\GraphmapsWpfControl\GraphmapsViewer.cs(2079,42,2079,51): error CS0104: 'FontStyle' is an ambiguous reference between 'System.Windows.FontStyle' and 'Microsoft.Msagl.Drawing.FontStyle'

[daveaglick]

Bummer. Might be something with the rebase. My changes don't touch the WPF control (and so I had it unloaded), but perhaps Git did a bad job with the automatic merge. I'll take a look and correct tomorrow, thanks.

[daveaglick]

Thanks!

[levnach]

I fixed the build of WPF stuff. Thanks!