Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this file - minor gramatical changes #1126

Closed
wants to merge 1 commit into from

Conversation

doctordns
Copy link
Contributor

@doctordns doctordns commented Mar 22, 2017

  1. Removed contractions for consistency and to improve readability especially for those who are not native English speakers.
  2. Remove future tense. Improves readability and ensures that the reader understands the specific features are available today.
  3. Changed discussion of pre/post scripts under Linux to remove passive voice and to clarify who calls the scripts. This improves reabaility.

Minor updates to a surperb article.

1. Removed contractions for consistency and to improve readability especially for those who are not native English speakers.
2. Remove future tense. Improves readability and ensures that the reader understands the specific features are available today.
3. Changed discussion of pre/post scripts under Linux to remove passive voice and to clarify who calls the scripts. This improves reabaility.

Minor updates to a surperb article.
@msftclas
Copy link

@doctordns,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jomolnar
Copy link
Contributor

@markgalioto Hi Mark. Please review these proposed contributions. Thanks.

@markgalioto
Copy link
Contributor

@doctordns Thank you for providing the feedback. My apologies, seriously, for not getting to this sooner. Because this article has been updated by others since your PR was submitted, there are merge conflicts. I am responsible for fixing those merge conflicts. So I've taken your fixes (except for un-doing the contractions), and submitted those in a separate PR which should go live very soon. You are correct that contractions can create issues for localization. But we are trying to create a more friendly tone for Azure documentation, and one of those ways is to use, or at least allow, contractions. Thanks again for your feedback.
#please-close

@PRmerger PRmerger closed this Apr 13, 2017
@doctordns
Copy link
Contributor Author

Thanks for the reply and thanks for fixing the issue. I appreciate your fixing this!

As for contractions - I am slightly confused, you seem to say you are in favour of minimising issues for localisation, then you say contractions are still ok? Hmmm. Elsewhere in the documentation, contractions HAVE been removed.

rajumsys pushed a commit to rajumsys/azure-docs that referenced this pull request May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants