Set service name correctly when using Azure Pipelines urls #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the CI job failed on ARM due to a bug within DotNet core, rather than a bug within the PR itself. See https://github.com/dotnet/coreclr/issues/18486 for details. |
|
@JacobHenner thanks for fixing this 👍 |
JacobHenner
force-pushed
the
fix/1841
branch
2 times, most recently
from
c08ec48
to
3618473
Compare
The previous service naming logic used the instance's subdomain. When an Azure Pipelines url was provided, "dev" was always used. Now, the instance name will be obtained from the url's path if an Azure Pipelines url is provided. Resolves microsoft#1841
JacobHenner
force-pushed
the
fix/1841
branch
from
3618473
to
8a78f97
Compare
|
This is ready for review. The CI job keeps failing for reasons unrelated to my change (different each time, oddly enough). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous service naming logic used the instance's subdomain. When an
Azure Pipelines url was provided, "dev" was always used. Now, the instance
name will be obtained from the url's path if an Azure Pipelines url is
provided.
Resolves #1841