run docker without sudo #2142
Merged
run docker without sudo #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
force-pushed
the
users/tihuang/dockernosudo
branch
from
6a6b53d
to
7c71202
Compare
dakale
approved these changes
Mar 8, 2019
|
|
||
| if (groupsOutput.Count > 0) | ||
| { | ||
| // check all potential username that might match the UID. |
There was a problem hiding this comment.
Should this be "check all potential groups that might match the GID? Otherwise LGTM
TingluoHuang
force-pushed
the
users/tihuang/dockernosudo
branch
from
7c71202
to
bc6e6b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might help #2056