Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background process can hold onto streams, causing jobs to not finish #389

Closed
vtbassmatt opened this issue Aug 9, 2018 · 2 comments
Closed
Labels

Comments

@vtbassmatt
Copy link
Member

On Linux, the test agents hang indefinitely under the following conditions:

  • A main process is launched by the agent
  • Main process launches a new process which inherits the handles of the main process
  • Main process exits before the child process

See https://github.com/natemcmaster/repro-vsts-stdout-blocking

We talked about addressing this by watching a couple of Node events and, if some threshold of time elapses between them, letting the user know what's happening. Optionally we could fulfill the promise so Node forcibly returns.

@nigurr
Copy link

nigurr commented Aug 10, 2018

@ericsciple We are also facing the same issue in test execution task. If test code leaves any stale process (typically chrome driver), we end up hitting task timeout in the end even though test execution is completed.

@ericsciple
Copy link
Contributor

fixed with commit 800dadc (forgot to close this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants