Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double-click not selecting @ in variable name #143

Closed
gbritton1 opened this issue Nov 18, 2017 · 6 comments · Fixed by #1990
Closed

double-click not selecting @ in variable name #143

gbritton1 opened this issue Nov 18, 2017 · 6 comments · Fixed by #1990
Labels
Area - Query Editor Enhancement Request for new features or functionality

Comments

@gbritton1
Copy link
Contributor

SQL Operations Studio Version: 0.23.6

Steps to Reproduce:
DECLARE @var int;

double-click on @var, only 'var' is selected

@bvogelzang
Copy link

You can fix this by removing the @ character in the editor.wordSeparators setting. I would agree that this should probably be excluded by default though.

word-separators

@gbritton1
Copy link
Contributor Author

that worked. thanks!

@kevcunnane
Copy link
Contributor

Thanks folks. I've reached out to the VSCode team to see if we can override this on a per-language basis. Ideally we'd just handle the fact SQL uses the @var pattern but most other languages treat this separately. Will keep the issue open until we hear back. We could override the default if necessary, but I'd prefer a more targeted fix.

@gbritton1
Copy link
Contributor Author

gbritton1 commented Nov 20, 2017

FWIW Python uses @ as the first character of a decorator name, as does Java.

@kevcunnane
Copy link
Contributor

I've created microsoft/vscode#39218 as a tracking issue for this. Ideally we should be doing this on a per-language basis rather than changing a global default. We can still consider changing this for all of Operations Studio but I think the "correct" solution is in that issue and is upstream of Ops Studio.

@kburtram
Copy link
Member

Please also investigate the '$. issue discussed in #224 when resolving this issue.

@yualan yualan added Enhancement Request for new features or functionality and removed Enhancement Request for new features or functionality labels Dec 7, 2018
@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area - Query Editor Enhancement Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants