Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests due to merge of PR #1017 #1023

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

cleemullins
Copy link
Contributor

If PR #1017, I took the change even though the build hadn't run. The build didn't run because Azure Devops isn't setup to run builds for external pull requests.

I looked at the change, confirmed the translation, and merged it it.... thinking, "This looks good. Nothing will break".

Sigh.

Tests should be passing now.

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleemullins
Copy link
Contributor Author

Build failed due to a Coveralls issue. All tests passed. Getting this PR merged in to fix the broken tests.

2018-10-11T22:56:49.6201685Z ##[command]"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a_temp\658024b9-c930-4d58-96e2-6e9e0684d9e1.ps1'"
2018-10-11T22:56:49.8364298Z Install tools
2018-10-11T22:56:51.8886618Z C:\Program Files\dotnet\sdk\2.1.402\NuGet.targets(114,5): error : Unable to get repository signature information for source https://api.nuget.org/v3/repository-signatures/index.json. [C:\Users\VssAdministrator\AppData\Local\Temp\nkw2zjwd.2br\restore.csproj]
2018-10-11T22:56:51.8887046Z C:\Program Files\dotnet\sdk\2.1.402\NuGet.targets(114,5): error : Response status code does not indicate success: 404 (Not Found). [C:\Users\VssAdministrator\AppData\Local\Temp\nkw2zjwd.2br\restore.csproj]
2018-10-11T22:56:52.1160992Z The tool package could not be restored.
2018-10-11T22:56:52.1161357Z Tool 'coveralls.net' failed to install. This failure may have been caused by:
2018-10-11T22:56:52.1161670Z
2018-10-11T22:56:52.1161947Z * You are attempting to install a preview release and did not use the --version option to specify the version.
2018-10-11T22:56:52.1162732Z * A package by this name was found, but it was not a .NET Core tool.
2018-10-11T22:56:52.1162964Z * The required NuGet feed cannot be accessed, perhaps because of an Internet connection problem.
2018-10-11T22:56:52.1163143Z * You mistyped the name of the tool.

@cleemullins cleemullins merged commit aec3b52 into master Oct 11, 2018
@cleemullins cleemullins deleted the CLM/FixDutchTests branch October 11, 2018 23:01
tomlm pushed a commit that referenced this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants