Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1255 - Added Skype for Business to channels list #1319

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

garypretty
Copy link
Contributor

Fix for #1255 - Added Skype for Business to channels list and updated oAuthPrompt to not use hardcoded strings.

… also updated oAuthPrompt to not use hardcoded strings.
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

However, before I merge, can you submit an Issue to the -js repo, to add these same constants there. If we have the issue added, the work will get done.

Once the issue is filed, I'll merge.

@garypretty
Copy link
Contributor Author

@cleemullins raised an issue on the JS side - microsoft/botbuilder-js#733

@garypretty garypretty deleted the update-channel-list branch January 29, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants