Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channels class has incomplete list of channel identifiers #1255

Closed
JonathanFingold opened this issue Dec 20, 2018 · 4 comments
Closed

Channels class has incomplete list of channel identifiers #1255

JonathanFingold opened this issue Dec 20, 2018 · 4 comments
Assignees
@johnataylor
Labels
4.3 February 14, 2019 Release triaged Reviewed by the Triage Team

Comments

@JonathanFingold
Copy link
Contributor

JonathanFingold commented Dec 20, 2018 •
edited

Version

Daily.

Describe the bug

The channels list is incomplete, missing channels visible in Azure: Bing and Skype for Business.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://github.com/Microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Connector/Channels.cs
    • Use a non-MS-internal account.
  2. Notice which channels are missing.

Expected behavior

All channels available through Azure have identifiers defined in the Channels class.

  • Bonus points for putting these constants in alpha order.

[bug]
@JonathanFingold
Copy link
Contributor Author

Also, is Bing still an available channel?

@cleemullins cleemullins added 4.3 February 14, 2019 Release Approved triaged Reviewed by the Triage Team labels Jan 9, 2019
@cleemullins
Copy link
Contributor

Note that the Bing channel is no longer supported. Verify this same change in the JS codebase.

garypretty added a commit to garypretty/botbuilder-dotnet that referenced this issue Jan 28, 2019
@garypretty
As per microsoft#1255 - added Skype for Business to channels list and…
8a84fbb 
… also updated oAuthPrompt to not use hardcoded strings.
@garypretty garypretty mentioned this issue Jan 28, 2019
Merged
@johnataylor johnataylor mentioned this issue Jan 29, 2019
Closed
cleemullins added a commit that referenced this issue Jan 29, 2019
@cleemullins
Merge pull request #1319 from garypretty/update-channel-list
c329715 
Fix for #1255 - Added Skype for Business to channels list
@cleemullins
Copy link
Contributor

Fixed in #1328

@cleemullins
Copy link
Contributor

Rather, fixed in #1319

@garypretty garypretty mentioned this issue Jan 29, 2019
Closed
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this issue Aug 25, 2020
@tracyboehrer
Merge pull request microsoft#1255 from microsoft/trboehre/readme
c3b4916 
Updated README to include info about pylint and black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnataylor johnataylor

Labels
4.3 February 14, 2019 Release triaged Reviewed by the Triage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sort and add missing channel name microsoft/botbuilder-dotnet
3 participants
@cleemullins @johnataylor @JonathanFingold