Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StyleCop] Fix all the warnings on several libraries #1618

Merged
merged 7 commits into from
Apr 9, 2019

Conversation

gasper-az
Copy link
Contributor

Libraries:

• Bot.Builder.AppInsights.Tests
• Bot.Builder.Integration.AppInsights.Core
• Bot.Builder.Dialogs.Tests
• Bot.Builder.AI.LUIS
• Bot.Builder
• Bot.ApplicationInsights.core.Tests

Changes made:

• Remove trailing whitespace
• Remove multiple blank lines in a row
• Add documentation for type parameter

@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2019

Pull Request Test Coverage Report for Build 53278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 76.121%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ServiceCollectionExtensions.cs 4 86.15%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizer.cs 6 79.49%
Totals Coverage Status
Change from base Build 53133: 0.0%
Covered Lines: 4361
Relevant Lines: 5729

💛 - Coveralls

@cleemullins
Copy link
Contributor

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@munozemilio
Copy link
Member

Hi @GasparAcevedoZainSouthworks, PR is approved but has conflicts, could you please fix those?

Thanks!

@gasper-az gasper-az force-pushed the fix/stylecop/several-libraries branch from bf0aa67 to c116ebd Compare April 4, 2019 20:07
@cleemullins
Copy link
Contributor

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll

@gasper-az
Copy link
Contributor Author

Hi @GasparAcevedoZainSouthworks, PR is approved but has conflicts, could you please fix those?

Thanks!

Hi @munozemilio, conflicts solved!!!

@cleemullins cleemullins merged commit 9a9765c into master Apr 9, 2019
@cleemullins cleemullins deleted the fix/stylecop/several-libraries branch April 9, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants