[StyleCop] Treat Warnings as Errors #1512

ceciliaavila · 2019-03-18T18:56:49Z

Solves ISSUE #1423

Description

Update the ruleset file to treat StyleCop warnings as errors

NOTE: To merge this PR is necessary that the PR #1473 is merged and that all the stylecop issues are solved.

gasper-az · 2019-04-08T20:14:07Z

This PR is ready for Review. However, it's important to notice that the Azure Build process will fail, as this PR attempts to treat the StyleCop Warnings as errors, and there are some remaining warnings to solve.

Note: the next PR fix the remaining Stylecop Warnings:

cleemullins · 2019-04-12T06:52:45Z

We're getting close to taking this. Are we ready? :)

gasper-az · 2019-04-12T21:24:26Z

We're getting close to taking this. Are we ready? :)

Hi @cleemullins, we created one last PR for fixing the remaining Stylecop Warnings, this is the PR #1668. Once PR #1668 is merged, we will be ready for merging this one.

Also, we created PR #1667, which revert the fixes made on the TestBot.WebApi project (with PR #1642) and ignore all the Warnings there. This is not necessary to merge for treating Warnings as Errors.

gasper-az · 2019-04-15T20:40:05Z

Hi @cleemullins,

We performed a last build of the whole Solution just for checking if there are some remaining Stylecop Warnings, but there isn't any of them. So, we can Merge this PR.

coveralls · 2019-05-27T12:14:11Z

Pull Request Test Coverage Report for Build 67994

0 of 0 changed or added relevant lines in 0 files are covered.
11 unchanged lines in 4 files lost coverage.
Overall coverage remained the same at 77.112%

Files with Coverage Reduction	New Missed Lines	%
/libraries/Microsoft.Bot.Builder.ApplicationInsights/BotTelemetryClient.cs	1	98.85%
/libraries/Microsoft.Bot.Builder.Dialogs/Choices/Find.cs	1	90.57%
/libraries/Microsoft.Bot.Builder.Azure/CosmosDbStorage.cs	3	49.74%
/libraries/Microsoft.Bot.Builder.AI.QnA/QnAMaker.cs	6	94.05%

Totals
Change from base Build 67957:	0.0%
Covered Lines:	4892
Relevant Lines:	6344

💛 - Coveralls

fuselabs · 2019-05-27T12:16:28Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

cleemullins · 2019-06-12T19:41:59Z

@ceciliaavila Are we ready to take this? Could you "touch" the PR so it triggers a new build? If the build passes, let's merge it in.

ceciliaavila · 2019-06-12T21:12:38Z

@ceciliaavila Are we ready to take this? Could you "touch" the PR so it triggers a new build? If the build passes, let's merge it in.

Hi @cleemullins, we just rebased this PR and found that there are new errors. We will be fixing them. Once they are solved, we will let you know.

ceciliaavila · 2019-06-13T20:09:01Z

@ceciliaavila Are we ready to take this? Could you "touch" the PR so it triggers a new build? If the build passes, let's merge it in.

Hi @cleemullins, we just rebased this PR and found that there are new errors. We will be fixing them. Once they are solved, we will let you know.

Hi @cleemullins, we created the PR #2068 with the fix of the new StyleCop issues. After it gets merged, we can rebase this PR to merge it too.
Thanks!

fuselabs · 2019-06-25T15:14:57Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

gabog · 2019-06-27T22:11:52Z

Hi @ceciliaavila, it looks like the branch got outdated, can you resolve the conflicts and ping me when is done and I will review again.

Thanks

Updated Directory.Build.Props to use the lates stable StyleCope (1.1.118) Removed documentation target from Directory.Build.Props (not used anymore). Removed <code>false</code>. tags that were upsetting StyleCop. Fixed a bunch of StyleCope issues that were generating compile errors. Fixed authentication namespaces

fuselabs · 2019-06-28T20:27:52Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

fuselabs · 2019-06-28T21:04:47Z

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

ceciliaavila mentioned this pull request Mar 18, 2019

[StyleCop] Treat Warnings as Errors #1468

Closed

ParadoxARG force-pushed the fix/set-stylecop-warnings-as-error branch 2 times, most recently from 40c63c6 to e4fdb6a Compare March 19, 2019 20:32

gasper-az marked this pull request as ready for review April 8, 2019 20:14

gasper-az force-pushed the fix/set-stylecop-warnings-as-error branch from e4fdb6a to 3e76b84 Compare April 9, 2019 18:28

gasper-az force-pushed the fix/set-stylecop-warnings-as-error branch from 3e76b84 to 18ebb95 Compare April 15, 2019 14:14

gasper-az mentioned this pull request Apr 15, 2019

Treat Warnings as Errors (StyleCop issues) #1423

Closed

JuanAr requested a review from cleemullins April 22, 2019 14:55

cleemullins added the 4.5 4.5 release label Apr 24, 2019

gasper-az force-pushed the fix/set-stylecop-warnings-as-error branch from 18ebb95 to 93d3fa3 Compare May 27, 2019 12:05

ceciliaavila force-pushed the fix/set-stylecop-warnings-as-error branch from 93d3fa3 to 2300af5 Compare June 12, 2019 21:06

ceciliaavila force-pushed the fix/set-stylecop-warnings-as-error branch from 2300af5 to c31dad3 Compare June 21, 2019 13:16

Bill7zz and others added 3 commits June 24, 2019 13:39

Add single and unified ruleset file

1cdf6e1

Set StyleCop warnings as errors

4ca7504

Fix new StyleCop issues in BotTelemetryClient.

74975f8

ceciliaavila force-pushed the fix/set-stylecop-warnings-as-error branch from c31dad3 to 74975f8 Compare June 24, 2019 17:40

ceciliaavila added 4 commits June 25, 2019 11:53

Fix StyleCop errors in LuisUtil and QnAMaker classes

1755ee4

Fix StyleCop errors in comments

5bfec91

Ignore rule SA0001-XML comment analysis

3a159ca

Add missing period in comment

b6fa769

gabog requested review from gabog and removed request for cleemullins June 27, 2019 22:11

cleemullins added 2 commits June 27, 2019 15:48

Merge branch 'master' into fix/set-stylecop-warnings-as-error

1e3b7d1

Merge branch 'master' into fix/set-stylecop-warnings-as-error

7c34135

cleemullins approved these changes Jun 28, 2019

View reviewed changes

gabog added 3 commits June 28, 2019 12:39

Merge branch 'master' into fix/set-stylecop-warnings-as-error

a76bf7f

Added temporary exclude for SA1609 (we need to fix this later)

12c1ddd

gabog approved these changes Jun 28, 2019

View reviewed changes

Touched the file to force rebuild

524867e

cleemullins merged commit 764fb15 into master Jun 28, 2019

cleemullins deleted the fix/set-stylecop-warnings-as-error branch June 28, 2019 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[StyleCop] Treat Warnings as Errors #1512

[StyleCop] Treat Warnings as Errors #1512

ceciliaavila commented Mar 18, 2019

gasper-az commented Apr 8, 2019

cleemullins commented Apr 12, 2019

gasper-az commented Apr 12, 2019

gasper-az commented Apr 15, 2019

coveralls commented May 27, 2019 •

edited

fuselabs commented May 27, 2019

cleemullins commented Jun 12, 2019

ceciliaavila commented Jun 12, 2019 •

edited

ceciliaavila commented Jun 13, 2019 •

edited

fuselabs commented Jun 25, 2019

gabog commented Jun 27, 2019

fuselabs commented Jun 28, 2019

fuselabs commented Jun 28, 2019

[StyleCop] Treat Warnings as Errors #1512

[StyleCop] Treat Warnings as Errors #1512

Conversation

ceciliaavila commented Mar 18, 2019

gasper-az commented Apr 8, 2019

cleemullins commented Apr 12, 2019

gasper-az commented Apr 12, 2019

gasper-az commented Apr 15, 2019

coveralls commented May 27, 2019 • edited

Pull Request Test Coverage Report for Build 67994

💛 - Coveralls

fuselabs commented May 27, 2019

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

cleemullins commented Jun 12, 2019

ceciliaavila commented Jun 12, 2019 • edited

ceciliaavila commented Jun 13, 2019 • edited

fuselabs commented Jun 25, 2019

gabog commented Jun 27, 2019

fuselabs commented Jun 28, 2019

fuselabs commented Jun 28, 2019

coveralls commented May 27, 2019 •

edited

ceciliaavila commented Jun 12, 2019 •

edited

ceciliaavila commented Jun 13, 2019 •

edited