Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json lacks version property resulting in broken builds of pre-existing bots using v4 preview #523

Closed
avoidwork opened this issue Oct 9, 2018 · 1 comment

Comments

@avoidwork
Copy link

avoidwork commented Oct 9, 2018

Versions

  • literally the problem, i want 4.0.0-preview1.2 and I get 4.0.6 on a fresh install

Describe the bug

package.json lacks a versions property, so package managers always install the latest version, breaking changes and all.

To Reproduce

Steps to reproduce the behavior:

  1. Try to install a version from npm that is not HEAD/4.0.6

Expected behavior

Older version installed

Screenshots

screen shot 2018-10-09 at 10 06 00 am

Additional context

Please, please version properly using semver tags & version values in package.json! Builds are non-deterministic over time atm, and it's a huge pain to be forced to upgrade a code base if you're simply deploying to a new vm in azure!

[bug]

@avoidwork
Copy link
Author

avoidwork commented Oct 9, 2018

The root issue lies in the semver version, and the solution is to remove ^ (caret) because 4.0.0-preview* is going to be determined to be lower than 4.0.6 because there was no 4.0.0 to lock onto; 4.0 starts at 4.0.6 as far as semver is concerned based on the tags in place.

"A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92."

screen shot 2018-10-09 at 10 21 28 am

package.json lacking a version attribute just adds to the confusion; versioning is simply 'wrong' on this project at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant