Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update model_fixes.js to set CardAction.channelData as an optional property #659

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Nov 26, 2018

First fix for #639

Description

Add "channelData" as an optional property for the CardAction interface.

Note: This doesn't fix #639 directly as the library needs to be regenerated. This PR sets it up so that then the library is properly regenerated (via the generateClient scripts), #639 will be fixed.

@stevengum stevengum requested a review from tomlm November 26, 2018 22:33
@stevengum
Copy link
Member Author

Pinging @sgellock as FYI

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2239

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 82.098%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build 2217: -0.06%
Covered Lines: 2633
Relevant Lines: 3088

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CardAction requires channelData property
3 participants