Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lerna to package.json devDependencies #802

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

Aliandi
Copy link
Contributor

@Aliandi Aliandi commented Feb 26, 2019

Fixes #774

Description

Even though it is necessary to have lerna installed globally to run commands such as npm i and npm run build, it is not listed on the devDependencies. This causes issues when trying to intall.
To avoid this, we added lerna as a devDependency on the package.json file.

Specific Changes

  • Add the "lerna": "^3.2.1" line to the package.json

Testing

Before adding the line:
imagen

After adding the line:
imagen

@coveralls
Copy link

coveralls commented Feb 26, 2019

Pull Request Test Coverage Report for Build #2024

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 87.441%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #2023: -0.06%
Covered Lines: 3004
Relevant Lines: 3306

💛 - Coveralls

@cleemullins cleemullins added bug Indicates an unexpected problem or an unintended behavior. 4.4 April 15, 2019 Release labels Mar 1, 2019
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I would prefer @justinwilaby or @benbrown look before we merge.

@cleemullins cleemullins merged commit 3b1e758 into microsoft:master Mar 1, 2019
@Aliandi Aliandi deleted the issue/lernaDependency branch March 1, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 April 15, 2019 Release bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants